NeoEden: add initial tests #1031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You sure you want to do this in one PR? I mean I'm going to help you all the way through, but my experience with that says we should do it in smaller steps |
shjala
force-pushed
the
make_eden_great_again
branch
from
73f2576 to
86fec04
Compare
hmm make sense, lets me rework it so we can have two eden in parallel. |
shjala
force-pushed
the
make_eden_great_again
branch
2 times, most recently
from
fd6c805 to
6ee8a2c
Compare
shjala
force-pushed
the
make_eden_great_again
branch
from
518c2d7 to
62f5dc6
Compare
The idea is to get rid of the escript and write tests using go testing infra. This is a first step twoards that goal. The main principales are 1. DRY and KISS. 2. Tests are grouped together (only smoke at the moment) 3. Tests broken into different categories based on what they test, like just EVE, or App or Network (for now just simple eve tests are ported) 5. Setup once and use in multiple tests, for example setup an app once and share it between (no-destructive) tests. Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
make_eden_great_again
branch
from
62f5dc6 to
8a05029
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
make_eden_great_again
branch
2 times, most recently
from
2cabe15 to
1c66635
Compare
- add LogTimeErrorf - add Ubuntu 20.04 app template Signed-off-by: Shahriyar Jalayeri <[email protected]> NeoEden : rename unused paramater to _ in vtpm_test.go Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]> NeoEden : renme unused parameter to _ in template/main_test.go Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
make_eden_great_again
branch
2 times, most recently
from
6c421d5 to
140c864
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
make_eden_great_again
branch
from
140c864 to
61307b5
Compare
|
I'm going to add the setup and teardown to this and then lets have a final round of review, I don't want to add more tests to it to bloat it more that it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really janky at the moment, but the idea is to get rid of the escrip and write tests using go testing infra.
TODO:
Test
Simply build and prepare :
and then :